Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete support for v1beta1 API w/o deleting the API itself. #1783

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Delete support for v1beta1 API w/o deleting the API itself. #1783

merged 1 commit into from
Mar 12, 2019

Conversation

kgolab
Copy link
Collaborator

@kgolab kgolab commented Mar 12, 2019

This makes v1beta1 objects handled via ConfigUnsupported condition, sample status of an v1beta1 object after the change:

status:
  conditions:
  - lastTransitionTime: 2019-03-12T13:13:01Z
    message: Label selector is no longer supported, please migrate to targetRef
    status: "True"
    type: ConfigUnsupported
  - lastTransitionTime: 2019-03-12T13:13:01Z
    status: "False"
    type: RecommendationProvided
  recommendation: {}

NOTE: This change is not flag-guarded since it didn't make sense to reuse beta1-api-deprecated flag and I didn't wanted to introduce another one. Please let me know if you want this otherwise.

PS. I haven't touched validation in this PR so one can still create v1beta1 objects. This will be part of a separate PR.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 12, 2019
@kgolab
Copy link
Collaborator Author

kgolab commented Mar 12, 2019

/assign bskiba@

@bskiba bskiba requested review from bskiba and removed request for MaciekPytel and mwielgus March 12, 2019 13:45
@bskiba bskiba self-assigned this Mar 12, 2019
bskiba
bskiba reviewed Mar 12, 2019
View reviewed changes
Copy link
Member

@bskiba bskiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2019
@bskiba
Copy link
Member

bskiba commented Mar 12, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bskiba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9733fe0 into kubernetes:master Mar 12, 2019
@kgolab kgolab mentioned this pull request Mar 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bskiba bskiba bskiba left review comments

Assignees

@bskiba bskiba

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgolab @bskiba @k8s-ci-robot